Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some WIN32 updates #879

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Some WIN32 updates #879

wants to merge 7 commits into from

Conversation

o-p-a
Copy link

@o-p-a o-p-a commented Jul 11, 2024 •
edited
Loading

I would like to suggest some improvements for Windows.

  • Version bump of workflow actions
  • Add manifest file
    • Set activeCodePage to UTF-8 (This allows to remove the wstring conversion in the source)
    • High DPI support
  • Improve window processing when starting the game (so that the emulator screen comes to the foreground, and ES comes to the foreground when the emulator is closed)
  • "Restart ES" in the exit menu was removed because it does not work on Windows that is not started from script
  • Utils::FileSystem::isExecutable() determined by the file extension on Windows

I mind affect as little as possible with mainstream Raspberry Pi builds.

@o-p-a o-p-a mentioned this pull request Jul 11, 2024
Closed
@cmitu
Copy link

cmitu commented Jul 11, 2024

  • Set activeCodePage to UTF-8 (This allows to remove the wstring conversion in the source)

FWIW, this works since Win 10 1903 (https://learn.microsoft.com/en-us/windows/apps/design/globalizing/use-utf8-code-page#set-a-process-code-page-to-utf-8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@o-p-a @cmitu